Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts file minor update for mui v5 #473

Closed
neporshiso opened this issue Feb 9, 2022 · 4 comments
Closed

index.d.ts file minor update for mui v5 #473

neporshiso opened this issue Feb 9, 2022 · 4 comments

Comments

@neporshiso
Copy link
Contributor

Hey Hossein -

Inside the index.d.ts file for notistack, the Transition Component type in the SnackbarProps interface is currently, TransitionComponent?: React.ComponentType.

However, in material-ui v5, https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Snackbar/Snackbar.d.ts#L100-L102, it's TransitionComponent?: React.JSXElementConstructor<TransitionProps & { children: React.ReactElement<any, any> }>.

Could this be updated to TransitionComponent?: React.ComponentType | React.JSXElementConstructor<TransitionProps & { children: React.ReactElement<any, any> }>;

for compatibility with mui v4 and mui v5 projects?

@iamhosseindhv
Copy link
Owner

Nice job @neporshiso I'll get this published asap

@cgarrovillo
Copy link

Is this merged yet?

@iamhosseindhv
Copy link
Owner

iamhosseindhv commented May 12, 2022

This issue is fixed in #474 and published as v2.0.5

@iamhosseindhv
Copy link
Owner

This issue is fixed in #474 and published as npm i [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants