New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Req] "ref" support for withSnackbar HOC. #84

Closed

jhrinoa opened this issue Mar 1, 2019 · 1 comment

Contributor

jhrinoa commented Mar 1, 2019

"ref" cannot be used a component that gets wrapped with withSnackbar HOC.
(Example: https://codesandbox.io/s/lp8ml9m52m)

I am wondering whether the next version of notistack can support ref using forwardRef.

If you agree, please note that React document suggest that this change should be a major version change.
https://reactjs.org/docs/forwarding-refs.html#note-for-component-library-maintainers

iamhosseindhv closed this as completed in

5dff56c

Owner

iamhosseindhv commented Apr 8, 2019

Thanks for pointing this out @jhrinoa. Fix is now on master and will be published in the next major release.

cleancoindev mentioned this issue

[Snyk] Upgrade hoist-non-react-statics from 3.3.0 to 3.3.2 cleancoindev/notistack#2

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment