Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnackbarProvider has incorrect typing for iconVariant #90

Closed
amakhrov opened this issue Mar 9, 2019 · 0 comments
Closed

SnackbarProvider has incorrect typing for iconVariant #90

amakhrov opened this issue Mar 9, 2019 · 0 comments

Comments

@amakhrov
Copy link
Contributor

amakhrov commented Mar 9, 2019

The current definition is

iconVariant?: React.ComponentType<SvgIconProps>;

which doesn't match the actual prop type defined in the component (.js file):

iconVariant: PropTypes.shape({
        /**
         * Icon displayed when variant of a snackbar is set to `success`.
         */
        success: PropTypes.any.isRequired,
        /**
         * Icon displayed when variant of a snackbar is set to `warning`.
         */
        warning: PropTypes.any.isRequired,
        /**
         * Icon displayed when variant of a snackbar is set to `error`.
         */
        error: PropTypes.any.isRequired,
        /**
         * Icon displayed when variant of a snackbar is set to `info`.
         */
        info: PropTypes.any.isRequired,
    }),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant