Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend functionality with createPortal optional approach #179

Merged
merged 5 commits into from
Dec 1, 2019
Merged

Extend functionality with createPortal optional approach #179

merged 5 commits into from
Dec 1, 2019

Conversation

PeterMK85
Copy link
Contributor

Scope:
Provide functionality to be able to render into React.createPortal

Issue Reported:
#178

@PeterMK85 PeterMK85 changed the title feat(createPortal): extend functionality with createPortal Extend functionality with createPortal optional approach Oct 9, 2019
@PeterMK85 PeterMK85 mentioned this pull request Oct 9, 2019
Merged
3 tasks
havenchyk
havenchyk approved these changes Oct 25, 2019
View reviewed changes
Copy link

@havenchyk havenchyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @iamhosseindhv could you please take a look?

@iamhosseindhv
Copy link
Owner

Thanks @PeterMK85 💙 . Would you be able to provide a sandbox demonstrating the new feature?
I'm happy to merge

@PeterMK85 PeterMK85 force-pushed the issue-178-create-portal-approach branch from 7ff0f49 to e181c3e Compare October 31, 2019 07:26
@PeterMK85 PeterMK85 force-pushed the issue-178-create-portal-approach branch from e181c3e to e16eb76 Compare October 31, 2019 07:35
@PeterMK85
Copy link
Contributor Author

@iamhosseindhv

Example sandbox:
https://codesandbox.io/s/notistack-simple-example-nqeep?fontsize=14

Note: If you debug you can see, that the parent element of the notistack will be react-notification not the root as the rest of the application

@PeterMK85
Copy link
Contributor Author

@iamhosseindhv
Do I need to provide anything else? Thanks 🙇‍♂️

@iamhosseindhv iamhosseindhv mentioned this pull request Nov 12, 2019
Closed
@iamhosseindhv
Copy link
Owner

Thanks for your contribution and patience @PeterMK85 . This didn't make it to v0.9.6 as I need to add an example to the website, and update docs. Will be published in v0.9.7.

@PeterMK85
Copy link
Contributor Author

@iamhosseindhv
Sorry for bothering, do we have an ETA for the v0.9.7 release?

@iamhosseindhv iamhosseindhv merged commit 2bcb075 into iamhosseindhv:master Dec 1, 2019
@PeterMK85 PeterMK85 deleted the issue-178-create-portal-approach branch December 2, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denieler denieler denieler approved these changes

@havenchyk havenchyk havenchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PeterMK85 @iamhosseindhv @havenchyk @denieler