Allow 0 as a snackbar key identifier #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, setting the `key` option to `0` will not respect it, and generate a random `id` based on `new Date().getTime() + Math.random()`. This fix will check if the value of `key` is `undefined` before defaulting to auto-generating the `id`. A specific use case for this would be when receiving payloads from an external source (like a subscription service), where the `id` could possibly start at `0`.
|
What if key is null or ''? |
based off feedback, would prefer to check if 0 directly, than implicit !== 'undefined'
|
I've changed it based off your feedback, @iamhosseindhv. |
|
Thanks @JimmyMultani 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, setting the
keyoption to0will not respect it, and generate a randomidbased onnew Date().getTime() + Math.random().This fix will check if the value of
keyisundefinedbefore defaulting to auto-generating theid.A specific use case for this would be when receiving payloads from an external source (like a subscription service), where the
idcould possibly start at0.