Enable passing children prop via enqueueSnackbar
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the SnackbarContent component
iamhosseindhv
changed the title
children prop via enqueueSnackbar
|
Thanks for your contribution @nijk. This will be merged in the next version of notistack. |
|
My pleasure, thanks for this lib - it's very useful 👍 |
|
@iamhosseindhv Any chance you can include this on v0.3.9? |
|
Thanks @iamhosseindhv |
|
@nijk Functionality has been added to master branch, and will be included in the next release. Thanks for reporting this and the PR. ❤️ |
|
amazing PR - please add to documentation as it took me a bit of time to find this. |
|
Good idea @nthgol. Would you open an issue for this |
|
I’ll create a PR tomorrow
…On Sat, Jan 26, 2019 at 3:54 PM Hossein Dehnokhalaji < ***@***.***> wrote:
Good idea @nthgol <https://github.com/nthgol>. Would you open an issue
for this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZMm3roxr7Gm58ikByU51EWzhUaO2-mXks5vHMBqgaJpZM4YSe9g>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 by rendering the
snack.childrenif it exists.