Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let MUI handle the font and border-radius #262

Merged
merged 1 commit into from
May 8, 2020

Conversation

fbarbare
Copy link
Contributor

@fbarbare fbarbare commented May 6, 2020

MUI calculates the rem size based on the HTML font size so hard coding the font size goes against their calculations and looks odd when HTML is e.g. 11px

https://material-ui.com/customization/typography/#html-font-size

image

MUI calculates the rem size based on the HTML font size so hard coding the font size goes against their calculations and looks odd when HTML is e.g. 11px

https://material-ui.com/customization/typography/#html-font-size
@iamhosseindhv iamhosseindhv merged commit 6d01111 into iamhosseindhv:master May 8, 2020
@iamhosseindhv
Copy link
Owner

Thanks for your contribution @fbarbare

@fbarbare fbarbare deleted the patch-1 branch May 11, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants