Fix snackbars of different width being left-aligned #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
Jun 3, 2021
Comment on lines
+23
to
+26
| pointerEvents: 'none', | ||
| [collapse.container]: { | ||
| pointerEvents: 'all', | ||
| }, |
There was a problem hiding this comment.
I found this part is making the snack bar untouchable. pointer-events never get unset to all. I guess collapse.container rules do not apply. Can you check again? Thanks
Jack-Works
reviewed
Jun 3, 2021
Comment on lines
+8
to
+9
| container: '& > .MuiCollapse-container', | ||
| wrapper: '& > .MuiCollapse-container > .MuiCollapse-wrapper', |
There was a problem hiding this comment.
Oh, I guess the problem is these two selectors. Those selectors do not appear in our DOM structure so pointer-events: all does not apply.
Jack-Works
reviewed
Jun 3, 2021
| @@ -4,37 +4,71 @@ import { makeStyles } from '@material-ui/core/styles'; | |||
| import { SNACKBAR_INDENTS } from './utils/constants'; | |||
| import { SnackbarProviderProps } from '.'; | |||
|
|
|||
| const useStyle = makeStyles(theme => ({ | |||
| const collapse = { | |||
| container: '& > .MuiCollapse-container', | |||
There was a problem hiding this comment.
This CSS class is deprecated. See mui/material-ui#24084
And I guess it is removed in v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #373 for more context.