Large diffs display wrong hours

[arrudaje]

Describe the bug
Due to this PR #2362, when we perform large diffs and construct a duration from it, the wrong number of hours is computed in the resulting duration. Example:

dayjs.duration(dayjs('2020-04-01 08:00:00').diff('2020-01-27 10:00:00')).format('HH:mm:ss') // displays '01:00:00'

Expected behavior

dayjs.duration(dayjs('2020-04-01 08:00:00').diff('2020-01-27 10:00:00')).format('HH:mm:ss') // should display '21:00:00'

Information

• Day.js Version: [v1.11.10]
• OS: [iOS]
• Browser: [chrome 120.0.6099.234]
• Time zone: [e.g. GMT+01:00 (Central European Standard Time)]

[arrudaje]

@sanjaynishad can you check this as you were the author of the PR?

[abemedia]

Just came to report the same...

const from = dayjs('2022-01-01 00:00:00');
const to = dayjs('2023-02-02 01:01:01');
const d = dayjs.duration(to.diff(from));
console.log(d.toISOString()); // prints "P1Y1M1DT15H1M1S" i.e. 15 hours, not 1

[buza-me]

@abemedia @arrudaje
#2571
#2572
I will not create any pull requests unless the repo owner will get interested. But you can use the code, if you didn't come up with your own solutions yet. Lmk if you spot some issues.