Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May I add an isoWeek plugin? #724

Closed
adamma1024 opened this issue Nov 7, 2019 · 3 comments
Closed

May I add an isoWeek plugin? #724

adamma1024 opened this issue Nov 7, 2019 · 3 comments

Comments

@adamma1024
Copy link

Describe the bug

  • It's a feature, not a bug !
  • Does't support to get week in standard of ISO8601

Expected behavior
I want to create isoWeek plugin to solve it ! It'll support these features:

  • dayjs().isoWeek() will return a number of week in standard of ISO8601
  • dayjs('2019').isoWeek( 3 ) will return an obj equal of dayjs('2019-01-11') which is the first day of 3rd ISO week in 2019

Information

  • Day.js Version [0.0.0-development]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome 62]
  • Time zone: [e.g. GMT-07:00 DST (Pacific Daylight Time)]
@iamkun
Copy link
Owner

iamkun commented Nov 7, 2019

Go ahead, please.

@Bourne115
Copy link

When can this feature be realized

@iamkun
Copy link
Owner

iamkun commented Mar 2, 2020 •
edited
Loading

added #811

Check isoWeek here https://day.js.org/docs/en/get-set/iso-week

@iamkun iamkun closed this as completed Mar 3, 2020
@Toub Toub mentioned this issue Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamkun @adamma1024 @Bourne115