-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception with prayer times [Bug] #46
Comments
@JMApps the problem is not with selecting "umm alqura uni, mekka" alone try to select it with other parameters I specified above, please |
@saifkandil Works fine for me and doesn't throw any exception, Hanafi method for asr prayer is selected in the screenshot and Umm al-Qura for prayer times. But I didn't understand "based on angle". |
@JMApps Sorry I didn't clarify it at first it's twilight angle for high latitude rule (I use it as Based on angle so that user can understand it) /// Rules for dealing with Fajr and Isha at places with high latitudes
enum HighLatitudeRule {
/// Fajr will never be earlier than the middle of the night, and Isha will never be later than
/// the middle of the night.
middle_of_the_night,
/// Fajr will never be earlier than the beginning of the last seventh of the night, and Isha will
/// never be later than the end of hte first seventh of the night.
seventh_of_the_night,
/// Similar to [HighLatitudeRule.seventh_of_the_night], but instead of 1/7th, the faction
/// of the night used is fajrAngle / 60 and ishaAngle/60.
twilight_angle
} In short, steps to reproduce is: set your |
did you managed to reproduce it? @JMApps |
Yes bro @k0T0z , I apologize for the late response. I reproduced it, you need to initialize: twilight_angle at the very end:
|
======== Exception caught by widgets library =======================================================
The following FormatException was thrown building HomeContentPrayerTimeItem(dirty):
ishaAngle's value isn't define
Describe the bug
when choosing "umm alqura uni, mekka" as a calculation method with "hanafi" as a madhab and "based on angle" as a high latitude rule the plugin returns an exception, this isn't supposed to happen.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The plugin must not return this exception
Screenshots
Environment(please complete the following information):
The text was updated successfully, but these errors were encountered: