feat: turn off some rules

[lucasvazq]

With this PR, I turn off some rules that are not required.

Here is the explanation:

• no-import-assign: It's configured with error in eslint-config-airbnb, but marked as off in plugin:@typescript-eslint/recommended
• no-setter-return: It's configured with error in eslint-config-airbnb, but marked as off in plugin:@typescript-eslint/recommended
• import/no-named-as-default-member: It's configured with error in eslint-config-airbnb, but the following typescript-eslint documentation recommends turning it off: TROUBLESHOOTING

[iamturns]

Thanks for the PR @lucasvazq

Sorry, but I don't think these rules belong in eslint-config-airbnb-typescript

An excerpt from the readme:

I wish this config would support [...]

This config simply enhances the Airbnb with TypeScript support. It's not a single config to cater for all TypeScript linting requirements. For additional functionality, alter your ESLint config file. For example:

module.exports = {
  extends: [
    'airbnb',
    'airbnb-typescript',
    'airbnb/hooks',
    'plugin:@typescript-eslint/recommended',
    'plugin:@typescript-eslint/recommended-requiring-type-checking',
  ],
};

[lucasvazq]

Hello @iamturns !

I understand your point. I just thought eslint-config-airbnb-typescript was copying some rules from plugin:@typescript-eslint/recommended. Why did I think this? Because I took a quick look and saw that these rules (eslint-config-airbnb-typescript:master) are very similar to the ones defined in this file (plugin:@typescript-eslint/recommended:main). Therefore, I had intuited that eslint-config-airbnb-typescript was outdated and I decided to create this PR to make an update.

If you still think you're right, feel free to close this PR.

[iamturns]

Hey @lucasvazq - great info, I appreciate all the links you added! I had embarssingly forgot about that chunk of code you listed 😊

I've been thinking on what to do.

Option 1: I like the idea of removing these rules from this config. Keeping this set of rules as slim as possible, and leaving other concerns to better suited plugins, allowing flexibility to consumers in stacking eslint configs as they prefer.

Option 2: I like the idea of keeping these rules in the config. They are enabled within airbnb config, but nobody wants them enabled in a TypeScript world, which feels within the realms of this plugin.

I think Option 2 makes the most sense, and your PR is a great enhancement. Thank you!

[iamturns]

🎉 This PR is included in version 16.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀