Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split into a main command package an an importable package. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Split into a main command package an an importable package. #22

wants to merge 1 commit into from

Conversation

dchapes
Copy link

@dchapes dchapes commented May 9, 2021 •
edited
Loading

Should resolve #18, and also resolve #20.

Also, add go.mod and go.sum for Go module support.

While adjusting the README for the above changes,
also expand on installation paths which should resolve #19.

@dchapes
Split into a main command package an an importable package.
ccee2e7 
Should resolve ichinaski#18 and ichinaski#20.

Also, add go.mod and go.sum for Go module support.

While adjusting the README for the above changes,
also expand on installation paths which should resolve ichinaski#19.
@dchapes
Copy link
Author

dchapes commented May 9, 2021

Note: I use mercurial with hggit so I'm not sure if the file copy of main.go to cmd/pxl/main.go was correctly detected as a repository file copy on the conversion to git (so that things like git blame within the new file will know what lines haven't been changed since the original).

Also note that this PR and my previous one at #21 are slightly incompatible in that they both muck with canvasSize in different ways, the former splits it out as unix and windows versions and this PR adds error handling. If you only want to accept one of these PRs and not the other for any reason, that'll work fine. If you do want both you can either adjust the error handing yourself or pick one to accept and I'll adjust/re-base the other to apply cleanly. Or, if you really want, I could combine the two PRs into a single new one.

Thanks.

This was referenced May 9, 2021
Closed
Closed
@bieli
Copy link

bieli commented Oct 3, 2023

@ichinaski It will be good to merge this PR. Everything was fine today when I cloned the related fork and ran the program with one command go build cmd/pxl/main.go. @dchapes +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dchapes @bieli