fix SMTP notification not sent #1007
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC you are trying solve two problems: a) that smtp notification is terminating the app when webui is enabled b) smtp notification is not supported for mfa requests. The solution is to send smtp notification on password/mfa requests while still keeping icloudpd with webui working to enter those credentials. Is the scope for initial auth only or re-auth as well? |
|
As long as the authenticator is called, it will also trigger the callback again. And indeed, it keeps it from exiting after sending the email. I also needed this to work better for #1008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898 #911
Before attacking the tests, let me know what you think of this approach.
Raising the exception will always exit the current code path in authentication.py