Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequence points on opening/closing braces #1245

Open
siegfriedpammer opened this issue Aug 2, 2018 · 1 comment
Open

Add sequence points on opening/closing braces #1245

siegfriedpammer opened this issue Aug 2, 2018 · 1 comment
Labels

Comments

@siegfriedpammer
Copy link
Member

Currently we only generate sequence points on statements. This makes the debugging experience a bit strange. We should at least add sequence points on the first and last IL offset of a method (mapped to the open/close brace) to prevent a sequence point from "hopping" into the next/previous method when trying to add a sequence point on a brace in VS. In debug builds these should ideally be on nop instructions.

@dgrunwald
Copy link
Member

We could do this in debug builds (where there's sufficient nop instructions); but it might be problematic in release builds to find a suitable instruction.
Picking a side-effect-free portion of another instruction (e.g. ldarg.0 for an opening brace) might damage stepping on that instruction if implicit IL sequence points are used instead of the PDB sequence points.
So I don't think this feature would be useful in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants