Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this expected? (UniversalAssemblyResolver fallback) #2891

Closed
CreateAndInject opened this issue Feb 1, 2023 · 3 comments
Closed

Is this expected? (UniversalAssemblyResolver fallback) #2891

CreateAndInject opened this issue Feb 1, 2023 · 3 comments
Labels
Bug Decompiler The decompiler engine itself

Comments

@CreateAndInject
Copy link
Contributor

// when decompiling assemblies that target frameworks prior to 4.0, we can fall back to the 4.0 assemblies in case the target framework is not installed.
// but when looking for Microsoft.Build.Framework, Version=15.0.0.0 we should not use the version 4.0 assembly here so that the LoadedAssembly logic can instead fall back to version 15.1.0.0
if (name.Version <= new Version(4, 0, 0, 0))
{
assembly = SearchDirectory(name, framework_dirs);
if (assembly != null)
return assembly;
}
if (throwOnError)
throw new ResolutionException(name, null, null);
return null;
}

Prior to 4.0 will fall back to .NET 6 rather than 4.0 as the comment indicate.

@siegfriedpammer
Copy link
Member

Can you provide an example please?

@CreateAndInject
Copy link
Contributor Author

dotnet1.1test.zip

@christophwille christophwille changed the title Is this expected? Is this expected? (UniversalAssemblyResolver fallback) Apr 7, 2023
@christophwille
Copy link
Member

Related #3011

@christophwille christophwille added Bug Decompiler The decompiler engine itself and removed Question/Query labels Jul 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Decompiler The decompiler engine itself
Projects
None yet
Development

No branches or pull requests

3 participants