Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 19: Standalone by default #78

Open
TomLBarden opened this issue Dec 18, 2024 · 1 comment
Open

Angular 19: Standalone by default #78

TomLBarden opened this issue Dec 18, 2024 · 1 comment

Comments

@TomLBarden
Copy link

TomLBarden commented Dec 18, 2024

Hi, as best I can tell this component does not declare that is it not standalone. Since Angular 19, components now default to being standalone, so when used in conjunction with a fix to ng-mocks seen here I get the following error:

Unexpected "MockOf_NgxScannerQrcodeComponent" found in the "declarations" array of the
"MockOf_NgxScannerQrcodeModule" NgModule, "MockOf_NgxScannerQrcodeComponent" is marked as standalone and can't
be declared in any NgModule - did you intend to import it instead (by adding it to the "imports" array)?

It seems like this project just needs to amend the component to declare standalone: false explicitly. I would produce a PR to do so except this repo doesn't seem to actually contain the source code.

@id1945
Copy link
Owner

id1945 commented Dec 21, 2024

@TomLBarden I will update for angular 19 as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants