fix: Typeahead expression search doesn't hit Bean Method with b

Fixes: KaotoIO#1027
igarashitm · Apr 26, 2024 · 65afad7 · 65afad7
1 parent 951343d
commit 65afad7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/packages/ui/src/components/Form/expression/ExpressionEditor.test.tsx b/packages/ui/src/components/Form/expression/ExpressionEditor.test.tsx
@@ -84,4 +84,29 @@ describe('ExpressionEditor', () => {
     });
     expect(inputElement).toHaveValue('');
   });
+
+  it('find bean method with a word bean', async () => {
+    const language = ExpressionService.getDefinitionFromModelName(
+      languageCatalog as unknown as Record<string, ICamelLanguageDefinition>,
+      'method',
+    );
+    render(
+      <ExpressionEditor
+        language={language}
+        expressionModel={{}}
+        onChangeExpressionModel={onChangeMock}
+      ></ExpressionEditor>,
+    );
+    const inputElement = screen.getAllByRole('combobox')[0];
+    await act(async () => {
+      fireEvent.change(inputElement, { target: { value: 'b' } });
+    });
+    const dropdownItems = screen.getAllByTestId(/expression-dropdownitem-.*/);
+    expect(dropdownItems).toHaveLength(6);
+    await act(async () => {
+      fireEvent.change(inputElement, { target: { value: 'bean' } });
+    });
+    const dropdownItems2 = screen.getAllByTestId(/expression-dropdownitem-.*/);
+    expect(dropdownItems2).toHaveLength(1);
+  });
 });
diff --git a/packages/ui/src/components/Form/expression/ExpressionEditor.tsx b/packages/ui/src/components/Form/expression/ExpressionEditor.tsx
@@ -79,8 +79,11 @@ export const ExpressionEditor: FunctionComponent<ExpressionEditorProps> = ({
 
     // Filter menu items based on the text input value when one exists
     if (filterValue) {
-      newSelectOptions = languageCatalogMap.filter((menuItem) =>
-        String(menuItem.value).toLowerCase().includes(filterValue.toLowerCase()),
+      newSelectOptions = languageCatalogMap.filter(
+        (menuItem) =>
+          String(menuItem.value).toLowerCase().includes(filterValue.toLowerCase()) ||
+          String(menuItem.children).toLowerCase().includes(filterValue.toLowerCase()) ||
+          String(menuItem.description).toLowerCase().includes(filterValue.toLowerCase()),
       );
       // When no options are found after filtering, display 'No results found'
       if (!newSelectOptions.length) {