Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Faraday or lock the dependency #152

Open
mensfeld opened this issue Jan 1, 2020 · 0 comments
Open

Upgrade Faraday or lock the dependency #152

mensfeld opened this issue Jan 1, 2020 · 0 comments

Comments

@mensfeld
Copy link

mensfeld commented Jan 1, 2020

given a change like so:

diff --git a/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock b/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock
index fe805f7..bd39031 100644
--- a/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock
+++ b/lib/offending_engine/harvesters/ruby/ducalis/isolate/Gemfile.lock
@@ -10,7 +10,7 @@ GEM
       regexp-examples (~> 1.3, >= 1.3.2)
       regexp_parser (>= 0.5.0)
       rubocop (>= 0.45.0)
-    faraday (0.17.1)
+    faraday (1.0.0)
       multipart-post (>= 1.2, < 3)
     git (1.5.0)
     jaro_winkler (1.5.4)

with a gemfile like so:

# frozen_string_literal: true

source 'https://rubygems.org'

gem 'ducalis'

when running ducalis:

gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14:in `<module:Middleware>'
gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:11:in `<module:Octokit>'
gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:9:in `<top (required)>'
gems/octokit-4.14.0/lib/octokit/default.rb:1:in `require'
gems/octokit-4.14.0/lib/octokit/default.rb:1:in `<top (required)>'
gems/octokit-4.14.0/lib/octokit.rb:4:in `require'
gems/octokit-4.14.0/lib/octokit.rb:4:in `<top (required)>'
gems/ducalis-0.12.0/lib/ducalis/utils.rb:3:in `require'
gems/ducalis-0.12.0/lib/ducalis/utils.rb:3:in `<top (required)>'
gems/ducalis-0.12.0/lib/ducalis.rb:26:in `require'
gems/ducalis-0.12.0/lib/ducalis.rb:26:in `<top (required)>'

I know, it's not directly related to this gem but rather to Faraday but I do believe Ducalis should be shipped with enough gemspec restrictions to run under valid conditions like presented above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant