Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding: fix indentation inconsistencies in generated proto files #1561

Open
lumtis opened this issue Sep 9, 2021 · 2 comments
Open
Labels

Comments

@lumtis
Copy link
Contributor

lumtis commented Sep 9, 2021

There may be different inconsistencies in the indentation for generated proto code: https://github.com/tendermint/spn/pull/294/files#r704611184 we should investigate them, fix and make generated proto files well formated. I believe 2 spaces for indentation.

Or we can check for a tool that autoformat proto code

@lumtis lumtis added the report label Sep 9, 2021
@lumtis lumtis added the component:spn Related to or beneficial for SPN development label Sep 9, 2021
@jaredalonzo
Copy link

I've noticed that the tx.proto's Msg service indents the first rpc by 3 tab characters whereas subsequent calls to scaffold message only indents by 1 tab character
Screen Shot 2022-01-02 at 3 40 50 PM
.

@fadeev fadeev added component:scaffold Feature, enhancement, or refactor related to scaffolding. and removed report labels Sep 17, 2022
@salmad3
Copy link
Member

salmad3 commented Feb 29, 2024

Check formatting state of files today. We can consider an additional linting tool to enforce formatting.

@salmad3 salmad3 added good first issue Good for newcomers type:chore and removed component:spn Related to or beneficial for SPN development component:scaffold Feature, enhancement, or refactor related to scaffolding. needs-triage labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants