Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility with v0.26.1 #3503

Closed
ilgooz opened this issue May 14, 2023 · 3 comments · Fixed by #3505
Closed

Backwards compatibility with v0.26.1 #3503

ilgooz opened this issue May 14, 2023 · 3 comments · Fixed by #3505
Assignees
Labels
type:error Something isn't working

Comments

@ilgooz
Copy link
Member

ilgooz commented May 14, 2023

Found some issue with backwards compatibility for the chain cmd set.

1st:

  • Scaffold a chain with v0.26.1 but try to chain build it with the nightly version. It says; github.com/cosmos/gogoproto couldn't be found. We should auto add this dependency to the tools.go if it doesn't present.

2nd:

  • After solving the 1st, try chain serve on the chain. I receive the following error:
✘ panic: error unzipping file description for MsgService venus.venus.Msg                                                
                                                                                                                      
goroutine 1 [running]:                                                                                                
github.com/cosmos/cosmos-sdk/types/msgservice.RegisterMsgServiceDesc({0x1077e4f20, 0x14001260cf0}, 0x1087aab60)       
	/Users/ilker/go/pkg/mod/github.com/cosmos/[email protected]/types/msgservice/msg_service.go:27 +0x640                
venus/x/venus/types.RegisterInterfaces({0x1077e4f20, 0x14001260cf0})                                                  
	/Users/ilker/Documents/code/src/github.com/ignite/test/venus/x/venus/types/codec.go:17 +0x2c                          
venus/x/venus.AppModuleBasic.RegisterInterfaces({{0x0, 0x0}}, {0x1077e4f20, 0x14001260cf0})                           
	/Users/ilker/Documents/code/src/github.com/ignite/test/venus/x/venus/module.go:54 +0x34                               
github.com/cosmos/cosmos-sdk/types/module.BasicManager.RegisterInterfaces(0x140015181b0, {0x1077e4f20, 0x14001260cf0})
	/Users/ilker/go/pkg/mod/github.com/cosmos/[email protected]/types/module/module.go:84 +0x9c                          
venus/app.MakeEncodingConfig()                                                                                        
	/Users/ilker/Documents/code/src/github.com/ignite/test/venus/app/encoding.go:33 +0xac                                 
venus/cmd/venusd/cmd.NewRootCmd()                                                                                     
	/Users/ilker/Documents/code/src/github.com/ignite/test/venus/cmd/venusd/cmd/root.go:44 +0x50                          
main.main()                                                                                                           
	/Users/ilker/Documents/code/src/github.com/ignite/test/venus/cmd/venusd/main.go:14 +0x38                              
: exit status 2                                                                                                       
@ilgooz ilgooz added the type:error Something isn't working label May 14, 2023
@ilgooz ilgooz changed the title Backwards compatibility Backwards compatibility with v0.26.1 May 14, 2023
@Pantani
Copy link
Collaborator

Pantani commented May 17, 2023

This PR fixes the tools dependencies, but the chain is not running not because of the ignite. You can try to run the chain using venusd start will not run anyway. We need to remove the first namespace from the proto file package name.

We should use venus.venus instead ignite.venus.venus, recompile the proto files and run.

@jeronimoalbi
Copy link
Member

It seems that the issue might be still happening so we should take another look at it.

@jeronimoalbi jeronimoalbi reopened this May 24, 2023
@jeronimoalbi
Copy link
Member

Closing again to continue it in #3515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:error Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants