Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a --gas flag for network commands #477

Closed
Tracked by #3115
ilgooz opened this issue Dec 3, 2020 · 6 comments · Fixed by #3114
Closed
Tracked by #3115

Implement a --gas flag for network commands #477

ilgooz opened this issue Dec 3, 2020 · 6 comments · Fixed by #3114
Assignees
Labels
component:network type:error Something isn't working
Milestone

Comments

@ilgooz
Copy link
Member

ilgooz commented Dec 3, 2020

No description provided.

@ilgooz ilgooz added the type:error Something isn't working label Dec 3, 2020
@fadeev
Copy link
Contributor

fadeev commented Dec 3, 2020

Noticed that as well. The amount of gas we use should probably be proportional to the approximate size of the tx.

@lumtis
Copy link
Contributor

lumtis commented Dec 3, 2020

spn side the MsgApprove can consume more than 200000, there may be something wrong in the logic of the approve handler.

Though we still need to put more gas proportionately to the number of messages in the tx

@lumtis
Copy link
Contributor

lumtis commented Dec 3, 2020

spn side the MsgApprove can consume more than 200000, there may be something wrong in the logic of the approve handler.

I actually can't reproduce this problem (I reported one MsgApprove which costs 300000 gas) so maybe it was related to an old implementation

@fadeev fadeev reopened this Oct 20, 2022
@fadeev fadeev changed the title fix(network): out of gas when trying to approve 6 proposals Implement a --gas flag for network commands Oct 20, 2022
@fadeev
Copy link
Contributor

fadeev commented Oct 20, 2022

I've noticed this is still an issue.

@lumtis lumtis added this to the T1 milestone Oct 20, 2022
@lumtis
Copy link
Contributor

lumtis commented Oct 20, 2022

I've noticed this is still an issue.
Because it has been solved in a older codebase not using cosmoscmd. I think the solution here will be to implement custom gas setting for tx with cosmoscmd

@amitkarpe
Copy link

Today when trying to approve multiple validators failed due to gas.
ignite n request approve ${chainid} 3-8

Don't have error message as of now. But once I reduce the number from 4 to 2 validators it resolved. ignite n request approve ${chainid} 3,4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:network type:error Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants