Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for .markdownlint.jsonc file by default #290

Closed
jjspace opened this issue May 25, 2022 · 1 comment
Closed

Check for .markdownlint.jsonc file by default #290

jjspace opened this issue May 25, 2022 · 1 comment

Comments

@jjspace
Copy link

jjspace commented May 25, 2022

The tool has the ability to parse a jsonc file but it doesn't look for it by default. This is one of the default configuration filenames that the vscode extension checks for so I had expected it to work.

I think it should just be a matter of changing:

const projectConfigFiles = ['.markdownlint.json', '.markdownlint.yaml', '.markdownlint.yml'];

To

const projectConfigFiles = ['.markdownlint.json', '.markdownlint.jsonc', '.markdownlint.yaml', '.markdownlint.yml'];
@DavidAnson
Copy link
Collaborator

That change makes sense, though I would put the new entry at the end of the list so it doesn't suddenly take precedence in cases where such a file is already present.

FYI, if you want the best compatibility with the VS Code extension, markdownlint-cli2 uses the same engine: https://github.com/DavidAnson/markdownlint-cli2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants