Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @ikalchev :) |
|
Sorry for the huge delay on that! |
bdraco
reviewed
Apr 1, 2024
| @@ -253,7 +255,15 @@ def setup_message(self): | |||
| Installation through `pip install HAP-python[QRCode]` | |||
| """ | |||
| pincode = self.driver.state.pincode.decode() | |||
| if SUPPORT_QR_CODE: | |||
| try: | |||
| from qrcode import QRCode | |||
There was a problem hiding this comment.
This does blocking IO in the event loop
| @@ -190,6 +186,12 @@ def xhm_uri(self) -> str: | |||
|
|
|||
| :rtype: str | |||
| """ | |||
| try: | |||
| import base36 | |||
There was a problem hiding this comment.
This does blocking IO in the event loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests run locally for
home-assistant/corewould fail with a cryptic "base36 is not defined" error if that library was not installed.This PR:
RuntimeErrorthat has the import error as a reasonpyhapnot importbase36orQRCodeat all until they are neededSUPPORT_QR_CODEflag; based on GitHub Code Search there are no external users for that flag that I can see.