Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No common config? #133

Open
GanerCodes opened this issue Jul 10, 2024 · 2 comments
Open

[Bug]: No common config? #133

GanerCodes opened this issue Jul 10, 2024 · 2 comments
Assignees
Labels
status: pending This issue or pull request is pending further information or development type: bug Something isn't working

Comments

@GanerCodes
Copy link

Minecraft Version

1.21.0

What happened?

Added mod, was configuring until I realized I as missing a bunch of options. Turns out it didn't make the common config file

How do you trigger this bug?

install veinminer

Loader

Fabric

Loader Version

fabric-api-0.100.6+1.21.jar

API Version

No response

Mod Version

veinmining-fabric-5.0.0-beta+1.21.jar

Relevant Log Outputs

it was at this point i checked the changelogs and it said it was removed. its prob cuz im stupid and have been awake 20 hours but i dont see how to configure the level and enchantment stuff. thats what this issue is now pls update the readme b/c the options aren't in the mod config tomls

@GanerCodes GanerCodes added status: triage This issue or pull request is awaiting review type: bug Something isn't working labels Jul 10, 2024
@TheIllusiveC4 TheIllusiveC4 added status: pending This issue or pull request is pending further information or development and removed status: triage This issue or pull request is awaiting review labels Jul 10, 2024
@TheIllusiveC4
Copy link
Member

All of the enchantment stuff is controlled by datapacks now due to the changes in vanilla making all enchantments data-driven. You can learn more about that here:
https://minecraft.wiki/w/Enchantment_definition

And this is the Vein Mining enchantment file:
https://github.com/illusivesoulworks/veinmining/blob/1.21.x/common/src/main/resources/data/veinmining/enchantment/vein_mining.json

I'm working on a way to bring back the common configuration, but it may take a while.

@GanerCodes
Copy link
Author

got it, thank you. for the time being i've modified my JAR file for a global config 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending This issue or pull request is pending further information or development type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants