Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large regression in time to complete tests #385

Closed
okaneco opened this issue Mar 2, 2023 · 2 comments
Closed

Large regression in time to complete tests #385

okaneco opened this issue Mar 2, 2023 · 2 comments

Comments

@okaneco
Copy link
Contributor

okaneco commented Mar 2, 2023

It takes ~7-8s on my machine to complete tests with commit b1cceaa. This balloons to ~48s in 43646cb.

encoder::tests::roundtrip and test encoder::tests::roundtrip_stream take much longer to finish. I can run tests in a different optimization profile to finish faster but posting this issue to see if it's replicable for anyone else.
@fintelia
Copy link
Contributor

fintelia commented Mar 4, 2023

I also see a regression:

7cbf35f  11.4s   (current main)
43646cb  11.4s
b1cceaa  4.0s

@fintelia
Copy link
Contributor

#384 upgrades fdeflate and should fix this

@okaneco okaneco closed this as completed Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fintelia @okaneco