Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for Importing Poses and Expressions #1370

Merged

Conversation

CaptainSticky
Copy link
Contributor

This pull request introduces some tweaks for importing poses to hopefully making posing easier with outdated body pose files and modern DT expression pose files. Here are the tweaks I've done:

  1. I noticed that when importing by Body Pose or by Selected Bones, the head bone (j_kao) wasn't getting posed, as its rotation was being reset by the facial expression hack. This could cause the head to not be posed as intended, and even do nothing when just importing that one bone. This tweak resolves that by conditionally applying the facial expression hack. Child bones like visor, hair, and Viera ears seem to be okay as they are parented.

  2. Facial expressions in DT now use bone positions, in addition to rotation and scale. This tweak adds bone positions to importing by Expression as well as restoring the head position in the facial expression hack. This allows users to import expressions completely, without having to do import by Full Transforms.

This has made posing easier for me. Pose first, then apply an expression, and finally a scale if desired. I've also been able to apply new expressions after posing, positioning, and scaling with these tweaks.

…ort by Selected.

Allow bone positions for head + face bones to be imported when importing by Expression.
Allow head (j_kao) position to be restored when importing by Expression.
@StoiaCode
Copy link
Contributor

A cursory glance appears to look good, you mention Viera ears seem okay, so I assume you tested it with different races? Mostly thinking about the different ear bones and earrings that used to occasionaly cause trouble.

This does feel like a sensible fix for now from my point of view 👍

@StoiaCode StoiaCode requested a review from chirpxiv August 12, 2024 15:53
@StoiaCode StoiaCode added Enhancement New feature or request Posing labels Aug 12, 2024
@CaptainSticky
Copy link
Contributor Author

Thanks for the reply!

Yeah! I did quick tests with a few races that I thought would be affected, such as Hrothgar, AuRa, and Viera. I took a closer look at Viera just now and really immersed myself in their ears. I learned a lot! My tweaks don't seem to affect posing the ears compared to the current version of Anamnesis.

There is an issue with the ears, however, that exists in the current version of Ana and that hasn't be affected by my changes. When doing a Full Transforms import, the ears (specifically the right one) will be a little lop-sided. Not sure if that's a symptom of changing my character into Viera.

@StoiaCode
Copy link
Contributor

Nope, thats been a thing forever. Its exactly one of those little quirks that made me ask in the first place. Viera ears tend to do silly things when position is involved, so I wanted to make sure this doesnt fuck up completely on Viera haha.

@StoiaCode StoiaCode merged commit c101046 into imchillin:master Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Posing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants