Tweaks for Importing Poses and Expressions #1370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces some tweaks for importing poses to hopefully making posing easier with outdated body pose files and modern DT expression pose files. Here are the tweaks I've done:
I noticed that when importing by Body Pose or by Selected Bones, the head bone (j_kao) wasn't getting posed, as its rotation was being reset by the facial expression hack. This could cause the head to not be posed as intended, and even do nothing when just importing that one bone. This tweak resolves that by conditionally applying the facial expression hack. Child bones like visor, hair, and Viera ears seem to be okay as they are parented.
Facial expressions in DT now use bone positions, in addition to rotation and scale. This tweak adds bone positions to importing by Expression as well as restoring the head position in the facial expression hack. This allows users to import expressions completely, without having to do import by Full Transforms.
This has made posing easier for me. Pose first, then apply an expression, and finally a scale if desired. I've also been able to apply new expressions after posing, positioning, and scaling with these tweaks.