Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sizes, and width descriptors #115

Closed
oyeanuj opened this issue Jul 18, 2017 · 3 comments
Closed

Support for sizes, and width descriptors #115

oyeanuj opened this issue Jul 18, 2017 · 3 comments

Comments

@oyeanuj
Copy link

oyeanuj commented Jul 18, 2017

Hey @frederickfogerty, thanks for putting out this library. Somewhat connected to #71, but while trying to use to do responsive images, I noticed that the library doesn't currently support sizes prop for <img>, or width descriptors (density descriptors seem to be supported via dpr) within srcSet.

Not sure if I missed something, or if there was a reason for that? If not, would this be something on the radar to add?

Thanks!

@oyeanuj
Copy link
Author

oyeanuj commented Mar 10, 2018

Just following up here, if there were any thoughts on this? Thank you!

@frederickfogerty
Copy link
Contributor

Hey there @oyeanuj!

I don't know a lot about sizes, and srcSet - could you please outline what you think the advantages and use cases (examples) of implementing each feature you've described would be? From there we can assess whether it should be added to the API.

Thanks :)

@frederickfogerty
Copy link
Contributor

This will be fixed in the next major version, v8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants