chore(readme): fix typo and update codesandbox examples #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickfogerty
changed the title
jayeb
approved these changes
Jul 5, 2018
frederickfogerty
added a commit
that referenced
this pull request
Jul 30, 2018
* chore(readme): fix typo and update codesandbox examples (#158) * chore(readme): fix typo in readme * chore(readme): edit codesandbox iframes to be links instead * chore(jest): upgrade jest to support new expect functions * test: use srcset and sizes - generateSrcSet -> disableSrcSet - remove aggressiveLoad - remove precision - add sizes top-level prop * chore: update build:watch to build es instead of commonjs * feat: add constants file and targetWidths from imgix.js * test: mock window.screen for unit tests * feat: use srcset and sizes - generateSrcSet -> disableSrcSet - remove - remove precision - add sizes top-level prop - remove empty img - remove defaultWidth and defaultHeight - remove fluid prop - remove auto-sizing behaviour in favour of srcsets - add check to ensure sizes is passed when in image mode and no width and heights have been passed * test: refactor alt test * test: refactor ixlib tests to use expectSrcTo * chore: stop using ...other in props * chore: rename support.js -> constructUrl.js * feat: add fallback srcset when using sizes * feat: update targetWidths with up to date reses, and remove max restriction * chore: remove fixed TODO * docs: update README for new srcSet/sizes * test: add srcSet test for <source> * feat: use 2x and 3x srcSets for pictures * docs: update markdown link * docs: add sizes doc * chore: cleanup unused code * chore: update targetWidth * feat: remove type=bg and add reference to issue * chore: remove availWidth and availHeight constants as they're not used * chore: update fit logic * test: remove type=bg tests * docs: remove reference to unimplemented aspect ratio behaviour * docs: add upgrade guide * chore: refactor some code to be more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a typo in README and fixes a problem with the CodeSandbox examples. GitHub does not allow rendering
iframeelements in the README, so the iframes were converted to links.Fixing typos
chore(readme): fixed typo