Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "fallback src" in srcset generation #227

Closed
jayeb opened this issue Nov 21, 2018 · 3 comments · Fixed by #224
Closed

Remove "fallback src" in srcset generation #227

jayeb opened this issue Nov 21, 2018 · 3 comments · Fixed by #224

Comments

@jayeb
Copy link

jayeb commented Nov 21, 2018

Describe the bug
We're currently adding a "sizeless" source URL to the end of our srcset attributes as a "fallback source", which is incorrect. The "fallback source" for an image element using the srcset attribute should be provided in the src attribute, not at the end of the srcset list.

See the lines in question here: https://github.com/imgix/react-imgix/blob/master/src/react-imgix.js#L124-L125

To Reproduce
N/A

Expected behaviour
Every item in the srcset list should include a size descriptor, which in our case is always a width value or a resolution multiplier.

Information:

  • react-imgix version: >= 8.0.0

Additional context
This issue is also present in imgix-rails, and is being fixed here: imgix/imgix-rails#69

@frederickfogerty
Copy link
Contributor

frederickfogerty commented Nov 22, 2018

I've managed to sneak this into #224.

@frederickfogerty
Copy link
Contributor

Fixed by #224

@frederickfogerty
Copy link
Contributor

Released in 8.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants