fix(background): fortify hasDOMDimensions
check for null height
#592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
hasDOMDimensions
to check for DOMwidth
andheight
, rather than just thetop
— which will exist in cases where we still don't want to consider the DOM dimensions "usable".This should fix #591 — which should, I imagine, stop Imgix from getting quite a few 400s
Checklist
Please use the checklist that is most closely related to your PR (you only need to use one checklist, and you can skip items that aren't applicable or don't make sense):
Bug Fix
fix(<area>): fixed bug #issue-number
N/A:
Steps to Test
The new unit test should be sufficient.
But if you want to test manually, too, then create a
<div style={{ width: 100, height: 0 }} /><Background /></div>
elementRelated issue: #591