Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-extraneous-dependencies - includeTypes option does not work when type keyword is applied to the whole line #2718

Closed
DetachHead opened this issue Feb 16, 2023 · 2 comments

Comments

@DetachHead
Copy link

import type { Foo } from 'foo' // no error
import { type Foo } from 'foo' // error
@ljharb ljharb closed this as completed in 6be042b Apr 8, 2023
@DetachHead
Copy link
Author

all that commit changed was adding a test, but i can't seem to reproduce the issue anymore, no idea why

@ljharb
Copy link
Member

ljharb commented Apr 11, 2023

@DetachHead yes, the test was passing, which means there's nothing to fix. It may have been fixed in a previous patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants