-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort-imports autofixer #547
Comments
Thanks for the heads up! We've been talking about this for a while. |
@eelyafi the link is now dead - is there an updated url? |
@magicmark the public link is dead, but the code lives inside Pinterest. Why ? |
@eelyafi why was it un-open-sourced? |
May be @arthuralee or @chrislloyd knows ? |
We moved our linters away from the semi-public (but not officially sanctioned) GitHub org. Most of the linters were for our old (now defunct) web framework and unfortunately I think @eelyafi's sort-imports was caught up :( No real reason, we'd be happy to share. |
@ljharb do you want me to share the source code ? |
@chrislloyd @eelyafi i was more interested in following your config overrides, and custom rules (that might be good candidates for upstreaming). Regardless it'd be great to attach a gist here of |
Only a couple of our rules would be relevant today - |
@eelyafi @arthuralee thanks so much for this. I'll take a look! for context I'm looking for ways that we can https://github.com/renke/import-sort provides the best coverage that I've found so far, but I'm eager do this in a way that doesn't rely on keeping two sets of import rules in sync (for linting and fixing) (maybe #711 is what I want) |
This can be closed |
Fixed by #908. |
It is nice to have autofixer for imports order.
In eslint plugin from Pinterest we already have sort-imports autofixer. Chris Lloyd mentioned that you guys might be interested in it.
https://github.com/pinterest-web/eslint-plugin-pinterest/blob/master/lib/rules/sort-imports.js
The text was updated successfully, but these errors were encountered: