Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error ESLint: <Flow-typed type definition> not found in module (import/named) #960

Open
budarin opened this issue Oct 26, 2017 · 7 comments
Labels

Comments

@budarin
Copy link

budarin commented Oct 26, 2017

I use to flow type checking & flow-typed defs in my project.
I have installed libDef for redux package also

import type { Store } from 'redux';
              ^^^ Error:() ESLint: Store not found in 'redux' (import/named)

Clicking to Store is pointed me to type definition file from flow-typed directory, but plugin state that such definition has not found in the module.
Though flow correctly identifies Store and displays type info in IDE

@ljharb ljharb added the flow label Oct 27, 2017
@budarin
Copy link
Author

budarin commented Nov 2, 2017

solved by adding node_modules into ignore section of .eslintrc settings

'import/ignore': [
  'node_modules'
]

@budarin budarin closed this as completed Nov 2, 2017
@ljharb
Copy link
Member

ljharb commented Nov 2, 2017

That “solution” means that you’re preventing this plugin from checking your third-party imports; this should be reopened.

@tf
Copy link

tf commented Apr 3, 2018

@ljharb Pushed a first attempt to fix this issue in #1060. Happy to incorporate feedback.

@budarin
Copy link
Author

budarin commented Apr 3, 2018

Hi!

will wait it in production to test! )

@ljharb
Copy link
Member

ljharb commented Sep 16, 2023

@budarin did you ever get a chance to see if this was fixed?

@budarin
Copy link
Author

budarin commented Sep 16, 2023

@ljharb

The fact is that this problem no longer bothers me - I switched to Zustand and I recommend doing all this :)

If especially nothing changes for such a long time - does it make sense to wait and keep this issue open?

On the other hand, there seems to be an issue to solve the problem #1060

If you think it's worth leaving the issue open, I'll open it...

@ljharb
Copy link
Member

ljharb commented Sep 16, 2023

#1060 was closed in favor of #1057, which was included in v2.12.0.

If the issue is indeed not yet fixed, it'd be ideal to leave the issue open no matter how long it's been, but if you can't verify it because you're no longer using Flow, then I suppose we can leave it closed.

@budarin budarin reopened this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants