From 421e695611f80ebb7c79288667a16b83914ca3a5 Mon Sep 17 00:00:00 2001 From: Janos Dobronszki Date: Thu, 24 Oct 2019 17:22:36 +0100 Subject: [PATCH] Minor changes --- pkg/e2e/spinup_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/e2e/spinup_test.go b/pkg/e2e/spinup_test.go index dad0fcf..8d60025 100644 --- a/pkg/e2e/spinup_test.go +++ b/pkg/e2e/spinup_test.go @@ -7,7 +7,6 @@ import ( "net/http" "os/exec" "strings" - "syscall" "testing" "time" @@ -123,8 +122,8 @@ func spinup(t testing.TB, ctx context.Context, cfg config) (chan error, error) { go func() { done <- cmd.Wait() }() - // This makes sure we get an output even it the binaries never stop, - // like it was the case with a SIGTERM bug. + // Timeout makes sure we get an output even it the binaries never stop, + // like it was the case with a Windows SIGTERM bug. timeout := time.After(5 * time.Second) var doneErr error @@ -145,7 +144,6 @@ func spinup(t testing.TB, ctx context.Context, cfg config) (chan error, error) { return doneErr }, func(error) { cmd.Process.Kill() - cmd.Process.Signal(syscall.SIGTERM) }) }