Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are speeds sometimes truncated as 20.27KiB[..].12KiBps? #214

Closed
NightMachinery opened this issue Mar 23, 2021 · 8 comments · Fixed by #305
Closed

Why are speeds sometimes truncated as 20.27KiB[..].12KiBps? #214

NightMachinery opened this issue Mar 23, 2021 · 8 comments · Fixed by #305
Assignees
Labels
bug Something isn't working fix submitted A tentative fix needs testing

Comments

@NightMachinery
Copy link

Why are speeds sometimes truncated as 20.27KiB[..].12KiBps?

This happens even on extremely low zooms:
image

@cyqsimon cyqsimon added the bug Something isn't working label Oct 16, 2023
@cyqsimon cyqsimon self-assigned this Oct 16, 2023
@cyqsimon cyqsimon added the fix submitted A tentative fix needs testing label Oct 16, 2023
@cyqsimon
Copy link
Collaborator

The table formatting logic used to be quite flawed. I've done a complete rewrite in #305, which should fix this issue. Please test and see if you are happy with it. You can either pull the table-layout-rewrite branch and build locally, or download the latest CI build.

Further improvement suggestions welcomed!

@cyqsimon
Copy link
Collaborator

Notifying everyone who thumbed-up this issue:
@Fabian42 @kescherCode @Rouzip @Michcioperz @jkmpariab @Abhinickz @NikitaPuzyryov @thundergolfer

@azzamsa
Copy link

azzamsa commented Oct 16, 2023

image

image

Getting better.

@kescherCode
Copy link

Much better from the table-layout-rewrite branch :D

Before After
image image

@cyqsimon
Copy link
Collaborator

I'm looking at the "Up / Down" column - maybe it would be better to put "per second" up in the column name?

So instead of this:

Up / Down
12.34KiBps / 56.78KiBps

We would have something like:

Up / Down speed (ps)
12.34KiB / 56.78KiB

What do you think?

@kescherCode
Copy link

@cyqsimon Indeed, this would make the only difference (in terms of table content) between normal and cumulative mode (-t) be the table header.

@cyqsimon
Copy link
Collaborator

Okay, normal mode (without -t) now looks like this:

New bandwidth display in normal mode

I don't think there is a need to put per second anywhere since it's pretty obvious that's what it is, plus real estate is expensive.

@cyqsimon
Copy link
Collaborator

Okay, by the lack of replies in this thread, seems like people are happy. I will go ahead and merge #305.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix submitted A tentative fix needs testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants