Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully when there is a broken pipe error #429

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

sigmaSd
Copy link
Collaborator

@sigmaSd sigmaSd commented Oct 7, 2024

pkexec bandwhich -r | ls

panics with

called `Result::unwrap()` on an `Err` value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }

This pr fixes the panic

@cyqsimon cyqsimon changed the title chore: exit gracefully when there is a broken pipe error Exit gracefully when there is a broken pipe error Oct 8, 2024
@cyqsimon
Copy link
Collaborator

cyqsimon commented Oct 8, 2024

Thanks, good catch.

Not really a chore though so I got rid of that from the title, otherwise LGTM.

@cyqsimon cyqsimon merged commit cc11fcb into imsnif:main Oct 8, 2024
25 of 36 checks passed
@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Oct 8, 2024

Thanks would be great if you make a new release with this

@cyqsimon
Copy link
Collaborator

cyqsimon commented Oct 8, 2024

NP will do so after #427.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 15, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [imsnif/bandwhich](https://github.com/imsnif/bandwhich) | patch | `v0.23.0` -> `v0.23.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>imsnif/bandwhich (imsnif/bandwhich)</summary>

### [`v0.23.1`](https://github.com/imsnif/bandwhich/releases/tag/v0.23.1)

[Compare Source](imsnif/bandwhich@v0.23.0...v0.23.1)

#### The middle east is on fire, yet again.

This is a maintainance release with a bug fix and dependency bumps:

-   Exit gracefully when there is a broken pipe error [#&#8203;429](imsnif/bandwhich#429) - [@&#8203;sigmaSd](https://github.com/sigmaSd)

#### What's Changed

-   CI: Use Powershell Compress-Archive to create Windows binary zip by [@&#8203;cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#424
-   chore(deps): bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 in the github-actions group by [@&#8203;dependabot](https://github.com/dependabot) in imsnif/bandwhich#428
-   Exit gracefully when there is a broken pipe error by [@&#8203;sigmaSd](https://github.com/sigmaSd) in imsnif/bandwhich#429
-   chore(deps): bump the dependencies group across 1 directory with 21 updates by [@&#8203;dependabot](https://github.com/dependabot) in imsnif/bandwhich#430
-   Fix breaking changes of `sysinfo` crate by [@&#8203;cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#431
-   Fix `clippy::needless_lifetimes` warnings on nightly by [@&#8203;cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#432
-   chore: `cargo update` by [@&#8203;cyqsimon](https://github.com/cyqsimon) in imsnif/bandwhich#433

**Full Changelog**: imsnif/bandwhich@v0.23.0...v0.23.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants