Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTF8 decoding error on some non UTF8 system #79

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

zhangxp1998
Copy link
Collaborator

@zhangxp1998 zhangxp1998 commented Jan 6, 2020

In response to issue #50

from_utf8_lossy will always succeed, it converts bytes to UTF8 string, escaping/discarding invalid bytes

@zhangxp1998
Copy link
Collaborator Author

Merging this PR because it's tiny in terms of LoC and change in functionality.

@zhangxp1998 zhangxp1998 merged commit 2412fc9 into imsnif:master Jan 6, 2020
@zhangxp1998 zhangxp1998 deleted the utf8 branch January 9, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant