Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev dependencies are losing "dev" flag #59

Closed
sebastienroux opened this issue Oct 1, 2020 · 2 comments · Fixed by #60
Closed

dev dependencies are losing "dev" flag #59

sebastienroux opened this issue Oct 1, 2020 · 2 comments · Fixed by #60

Comments

@sebastienroux
Copy link

Issue description:

Hello,
With last version 1.9.3 when converting yarn.lock, dev dependencies are losing their flag "dev", please compare lock files :

Are you reporting a conversion error? Please include a link to yarn.lock / package-lock.json:

package-lock.json converted with synp
package-lock.json from npm install
yarn.lock

Are you reporting a conversion error? Please also include a link to your package.json:

{ "name": "angular-version", "version": "0.0.0", "license": "MIT", "private": true, "dependencies": { "rxjs": "~6.6.2" }, "devDependencies": { "protractor": "~7.0.0" } }

@antongolub
Copy link
Collaborator

antongolub commented Oct 1, 2020

Hey, @sebastienroux,

I've just tweaked up dev flag resolver. From now all the packages that are out of dependencies field of their parents marked as dev. This should help. Release is on the way.

before

if (has(nodeModulesTree[parentPackagePath(mPath)], `devDependencies.${name}`)) {
  entry.dev = true
}

after

if (!has(nodeModulesTree[parentPackagePath(mPath)], `dependencies.${name}`)) {
    entry.dev = true
}

antongolub added a commit that referenced this issue Oct 1, 2020
## [1.9.4](v1.9.3...v1.9.4) (2020-10-01)

### Bug Fixes

* mark all the packages that are out of `dependencies` as `dev` ([f6dbccd](f6dbccd)), closes [#59](#59)
@antongolub
Copy link
Collaborator

🎉 This issue has been resolved in version 1.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants