Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITE-7: Route to acceptance #33

Open
adityasaky opened this issue Jul 1, 2022 · 8 comments
Open

ITE-7: Route to acceptance #33

adityasaky opened this issue Jul 1, 2022 · 8 comments

Comments

@adityasaky
Copy link
Member

ITE-7 was merged as draft back in February. Considering there's implementation support for it in in-toto-golang, this ITE is at a point where we can consider it for acceptance. The ITE has been stable for some time now, as has its implementation. Are there any outstanding issues that need to be addressed first?

@adityasaky
Copy link
Member Author

cc @mikhailswift @colek42

@elfotografo007
Copy link

Hi, I was reviewing the ITE but I found that the prototype implementation link is broken.

@colek42
Copy link
Member

colek42 commented Jul 13, 2022

@elfotografo007 ITE-7 has been upstreamed to in-toto golang. We also implement it in witness

@colek42
Copy link
Member

colek42 commented Jul 13, 2022

@adityasaky we are not having any issues with it. I vote for acceptance

@elfotografo007
Copy link

I vote for acceptance as well.

@mikhailswift
Copy link
Member

No outstanding issues known currently

@adityasaky
Copy link
Member Author

as @elfotografo007 noted, we should probably update the ITE pointing to the in-toto-golang implementation as well as witness. I think infrastructure requirements, testing, and references could use a pass as well.

@adityasaky
Copy link
Member Author

#34 has been merged. The next step for ITE-7 is for the changes in #34 to be implemented in in-toto-golang. If everything looks good there, we should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants