Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Speed up the git status part of the git attestor #358

Closed
matglas opened this issue Sep 24, 2024 · 1 comment · Fixed by #359
Closed

[Feat]: Speed up the git status part of the git attestor #358

matglas opened this issue Sep 24, 2024 · 1 comment · Fixed by #359
Labels
feature New feature (larger than enhancement)

Comments

@matglas
Copy link
Contributor

matglas commented Sep 24, 2024

Describe the solution you'd like:

The current part that is capturing the git status in the git attestor is slow especially when using a large repository. Go-git does not do threading and capturing the status takes a long time because of that.

User value:

By improving the speed users with larger repositories will see a significant speed up in the execution time of witness. This plays a part in adoption. As a DevOps engineer I want to keep my pipelines fast but I do want to capture attestations with Witness.

Expected behavior:

Status should be captured as fast as doing a normal git status on a repo.

Proposed solution:

Replace go-git or use git cli as a hybrid solution to capture the status of the repo in the attestation.

Testing changes required:

TBD

Documentation changes required:

TBD

@matglas matglas added the feature New feature (larger than enhancement) label Sep 24, 2024
@matglas
Copy link
Contributor Author

matglas commented Sep 24, 2024

I think this might be an enhancement. But we can't set labels and this template worked the best 😄
@jkjell can you adjust this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature (larger than enhancement)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant