Oversight in the SLAS v1 field invocationID?

[chuangw6]

Description of the bug:

In the SLSA v1 provenance, the json tag for the field invocation id should be invocationId instead of invocationID per slsa v1 spec on the official website and the proto.

But the tag in in-toto-golang is invocationID

in-toto-golang/in_toto/slsa_provenance/v1/provenance.go

Line 144 in 5fd5c67

InvocationID string `json:"invocationID,omitempty"`

[chuangw6]

cc @adityasaky

[adityasaky]

I think it's preferable to fix this by directly using the proto. I know @marcelamelara was interested in getting this done too, unfortunately I've been a little swamped. @marcelamelara do you have any cycles to help out here?

[chuangw6]

I think it's preferable to fix this by directly using the proto.

Agreed.

[marcelamelara]

+1 to switching to using the protobufs in this implementation. IIRC, the last time I looked at making this change happen, it wasn't quite as simple as replacing one struct for the other, but I'll have some cycles in the next week or two, so I can take a look.

[msuozzo]

The aforementioned change is still not submitted so the proto version is effectively unusable. Can we merge the fix for this issue in the meantime? #328

[msuozzo]

Is this worth a patch-release? This is technically a bug fix but I can pin to the commit hash if necessary.

[adityasaky]

I'll try and tag a release tomorrow. There are a couple pending updates etc we should probably merge as well, I'll check if someone has a few to take a pass at fixing some of the CI issues!