Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare the way we store symlinks in our link metadata to the reference implementation #57

Open
shibumi opened this issue Jun 23, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shibumi
Copy link
Collaborator

shibumi commented Jun 23, 2020

Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.

Description of issue or feature request:
We still need to decide if link metadata stores the path of the source or the target of a symlink.
The python reference implementation is might be useful for this.

Current behavior:

unknown

Expected behavior:

see python reference implementation

@shibumi
Copy link
Collaborator Author

shibumi commented Jun 23, 2020

See PR #37 and #55

@shibumi shibumi added the enhancement New feature or request label Jan 15, 2021
@adityasaky
Copy link
Member

This came up in #191. There was an artifact path collision when it should have recorded the link paths (both would still have the same hash). The python implementation does this as well and I think it makes the most sense.

@adityasaky
Copy link
Member

@shibumi do you think we can consider this done with #194 merged?

@shibumi
Copy link
Collaborator Author

shibumi commented Jan 17, 2023

Good question. I would suggest running in-toto-golang and the python implementation and testing if they really create the same output.

We really need some sort of automated tests that regularly run the Go and Python implementations and make sure that they produce consistent and equal output.

@adityasaky
Copy link
Member

This should be a test case for in-toto/in-toto#563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants