Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate functions, specifically key validations #68

Open
shibumi opened this issue Aug 16, 2020 · 1 comment
Open

validate functions, specifically key validations #68

shibumi opened this issue Aug 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@shibumi
Copy link
Collaborator

shibumi commented Aug 16, 2020

Description of issue or feature request:
Right now, most or even all of our validate functions in the model.go file are unexported.
It needs to be discussed, if we want to export these functions or if we only want to use them internally.

Furthermore the validateKeyVal function is not being used right now, because most of the functionality
is already being covered by internal code in the GenerateSignature, ValidateSignature and LoadKey functions.

We also might want to talk about key validation in general. Are we happy with the current approach? Should
we do it differently? What requirements do we have on a valid key actually? What kind of mistakes are forgivable?
When is a key definitely invalid?

I would also like to use this issue to highlight a small nit: Right now, we are mixing the words validation and verification
in many places. Might make sense to use these words in different situations and keep the wording consistent.

@shibumi shibumi mentioned this issue Aug 16, 2020
2 tasks
@lukpueh
Copy link
Member

lukpueh commented Aug 17, 2020

Some discussion around validation functions took place in #56 (comment) and #56 (comment), and in inline comments of #56 (review).

There is also to be learned from the issues with the type/format validation facility of the in-toto reference implementation: secure-systems-lab/securesystemslib#183

@shibumi shibumi added the enhancement New feature or request label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants