Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form defaults not working #1195

Closed
betaSavvy opened this issue Jun 8, 2022 · 4 comments
Closed

Form defaults not working #1195

betaSavvy opened this issue Jun 8, 2022 · 4 comments

Comments

@betaSavvy
Copy link

Versions:

  • @inertiajs/inertia version: 0.11.0
  • @inertiajs/inertia-vue3 version: 0.6.0

Describe the problem:

form.defaults() is not working.

Steps to reproduce:

In the page, I have a form like this

form = useForm({
  foo: '',
});

On page load, i call this function

const initForm = () => {
  form.foo = 'bar';

  // Set the form's current values as the new defaults
  form.defaults();
}

I setup a button to console.log the result of form.isDirty and it always return true. Did I misunderstand the usage of defaults? I have also tried it with the following:

// Update the default value of a single field
form.defaults('foo', 'bar');

// Update the default value of multiple fields
form.defaults({ 
  foo: 'bar',
});
@RobertBoes
Copy link
Contributor

RobertBoes commented Jun 8, 2022

form.defaults() only updates the defaults, it leaves the current form intact. You'd have to call form.reset() after updating the defaults if you want to reset the current fields to the (new) defaults.

@flavio-schoute
Copy link

I hope this changes with the 1.0.0 version because this makes no sense at all.

@reinink
Copy link
Member

reinink commented Apr 14, 2023

I hope this changes with the 1.0.0 version because this makes no sense at all.

What does make sense here? Should form.defaults() also immediately reset the form data? What if you only want to update the defaults and not reset the form?

I'm not sure it will help in every situation, but last night I added an option to the form helper in the Vue adapters to allow providing an initialization callback that's automatically run when resetting a form. Check that out here: #1516

@reinink
Copy link
Member

reinink commented Jul 28, 2023

Hey! Thanks so much for your interest in Inertia.js and for sharing this issue/suggestion.

In an attempt to get on top of the issues and pull requests on this project I am going through all the older issues and PRs and closing them, as there's a decent chance that they have since been resolved or are simply not relevant any longer. My hope is that with a "clean slate" me and the other project maintainers will be able to better keep on top of issues and PRs moving forward.

Of course there's a chance that this issue is still relevant, and if that's the case feel free to simply submit a new issue. The only thing I ask is that you please include a super minimal reproduction of the issue as a Git repo. This makes it much easier for us to reproduce things on our end and ultimately fix it.

Really not trying to be dismissive here, I just need to find a way to get this project back into a state that I am able to maintain it. Hope that makes sense! ❤️

@reinink reinink closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants