fix: enable strict mode for TS types #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusnunes89
approved these changes
Jun 4, 2024
|
Is there anything that needs to be done to move forward with this PR? I'm trying to upgrade our large app to RN 0.74 and that uses TypeScript 5, at which point there's no way out of type checking imported .ts dependencies. Because I'd be happy to help if we could get a version released that works with latest RN versions, given Flipper is removed in those versions Reactotron is more needed than ever. 😄 |
bruno-fialho
suggested changes
Sep 3, 2024
There was a problem hiding this comment.
There are also problems in:
- "src/stopwatch.ts":
typeof window !== "undefined" &&=> Cannot find name 'window'.performanceNow(started)[1]=> Element implicitly has an 'any' type because expression of type '1' can't be used to index type 'Number'.
- "src/validate.ts"
typeof host === "string" && host && host !== ""=> Type 'string | boolean' is not assignable to type 'boolean'.!isHostValid(host)=> Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.!isPortValid(port)=> Argument of type 'number | undefined' is not assignable to parameter of type 'number'. Type 'undefined' is not assignable to type 'number'.!onCommandValid(onCommand)=> Argument of type '((command: any) => void) | undefined' is not assignable to parameter of type '(cmd: string) => any'. Type 'undefined' is not assignable to type '(cmd: string) => any'.
| @@ -60,7 +60,7 @@ function serialize(source, proxyHack = false) { | |||
| * @param {*} value - The value to replace. | |||
| */ | |||
| function serializer(replacer) { | |||
| @@ -352,7 +355,7 @@ export class ReactotronImpl implements ReactotronCore { | |||
| } | |||
|
|
|||
| // this is ws style from require('ws') on node js | |||
| if ("on" in socket && socket.on) { | |||
| if ("on" in socket && socket.on!) { | |||
|
Any movement on this PR? I'm seeing these TS errors 👀 @bruno-fialho @marcusnunes89 |
3 tasks
|
ready to merge? 👀 🚀 @marcusnunes89 |
|
@tabbathacrouch I don't have permission to merge, I'm just one of those who want this fixed so I can use it :P |
joshuayoes
approved these changes
Oct 29, 2024
|
Thank you for this addition! Sorry this sat for so long. Our open source labor at Infinite Red relies on contributions from our team members during downtime between client projects and donations of our free time, so sometimes painful issues like this fall through the cracks. We needed to do a little more work to get our |
|
Is there a way to use or do we need to wait for an update to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
This PR enables strict mode for the
reactotron-core-clientcodebase to fix issues documented here:#1430