influxdb-java-182 Allow write precision of TimeUnit other than Nanoseconds #321
Conversation
|
This PR cant be merged because of conflicts, please first fix this. |
…-java-182 # Conflicts: # src/test/java/org/influxdb/dto/PointTest.java
…conds checkstyle violations fix
…conds tests failing fixes
…conds tests failing fixes
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
============================================
+ Coverage 86.04% 86.48% +0.43%
- Complexity 293 301 +8
============================================
Files 20 20
Lines 1261 1287 +26
Branches 133 134 +1
============================================
+ Hits 1085 1113 +28
+ Misses 116 114 -2
Partials 60 60
Continue to review full report at Codecov.
|
|
please verify the tests and process is correct before merging |
|
for this single feature addition ~450 changed lines seems way too much. |
|
450 lines of which half are the unit tests, but I also had trouble with the automatic code formatting (especially on the imports) and I didn't fix them all I guess. |
|
To me this looks like a very well done PR including numerous tests. 👍 |
| */ | ||
| public String lineProtocol(final TimeUnit precision) { | ||
| final StringBuilder sb = new StringBuilder(); | ||
| sb.append(KEY_ESCAPER.escape(this.measurement)); |
|
Yes this PR is in a shape we can merge, but i also want to wait for the next iteration. Once the actual version is published to maven central i will merge this as well. |
|
@joelmarty can you please fix the actual merge conflicts? i will merge then. |
# Conflicts: # src/main/java/org/influxdb/dto/Point.java
…conds merged changes from 2.6 release
…conds fix merge errors
|
Thanks, but still build is failing, dont know exactly why. |
|
because it's a fucking nightmare to merge the changes now that a release has moved code all around. Might as well redo the feature from scratch. |
|
I'm sorry for that, but i had a bunch of PR's for this sprint and either order of merge lead to conflicts of others. |
|
I will have to delay working on this later this week or month, I don't have
time right now
Le mer. 14 juin 2017 à 13:12, Stefan Majer <[email protected]> a
écrit :
… I'm sorry for that, but i had a bunch of PR's for this sprint and either
order of merge lead to conflicts of others.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIOszkaxYpfDujhE3YU1MvlNjsblmXcks5sD7j7gaJpZM4Njj6I>
.
|
|
Hi there. Any news on this? We would like to get release 2.8 as soon as possible. |
|
@majst01 : I fixed the merge conflicts, please check and merge this PR |
| /** | ||
| * @param precision the time precision to set for the batch points | ||
| */ | ||
| public void setPrecision(final TimeUnit precision) { |
There was a problem hiding this comment.
Why is this setter public, we have a builder which is responsible to do the object creation ?
There was a problem hiding this comment.
well, seems this long-standing PR has not attracted its author anymore. Let me see if I can help something
|
OK, now im fine, @lxhoan can you add a changelog entry ? |
|
change log added |
|
Thank you for taking care of this! |
|
@joelmarty , you're welcome |
I worked on this a while ago, I was waiting for an answer before commiting so it can't be merged automatically, sorry about that!
Also I wrote some tests but since there's no public test environment I couldn't make them run.