Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple but significant performance improvements. #330

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

brettwooldridge
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #330 into master will increase coverage by 0.24%.
The diff coverage is 94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     79.66%   79.91%   +0.24%     
  Complexity      137      137              
============================================
  Files            11       11              
  Lines           723      732       +9     
  Branches         78       76       -2     
============================================
+ Hits            576      585       +9     
+ Misses          106      104       -2     
- Partials         41       43       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java 83.49% <100%> (+0.8%) 43 <1> (ø) ⬇️
src/main/java/org/influxdb/dto/Point.java 83.22% <92.85%> (-0.11%) 24 <3> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df18f64...901bf4f. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Jun 1, 2017

Can you show how big the performance improvements are ?

@majst01 majst01 added this to the 2.7 milestone Jun 1, 2017
@brettwooldridge
Copy link
Contributor Author

Locally measured.

Current:

Single Point Write for 10000 writes of Points took:240.6 ms
5Mio points:7.300 s

New:

Single Point Write for 10000 writes of Points took:192.6 ms
5Mio points:5.306 s

@brettwooldridge
Copy link
Contributor Author

More difficult to measure, though measurable, and not insignificant, is the reduction of garbage.

@majst01
Copy link
Collaborator

majst01 commented Jun 1, 2017

Great thanks, i will merge it in the next iteration.
Thanks for your contribution.

@brettwooldridge
Copy link
Contributor Author

@majst01 Thanks! We may have more contributions in the coming weeks.

… and

generates > 800MB less garbage in the PerformanceTests.maxWritePointsPerformance()
test compared to the master branch.
@brettwooldridge
Copy link
Contributor Author

Latest commit gets the maxWritePointsPerformance() test down to 5Mio points: 4.781 s compared to 5Mio points:7.300 s on master. Also generates +800MB less garbage (yes, that test generates several gigabytes of garbage).

@brettwooldridge
Copy link
Contributor Author

@majst01 A few questions. I see that v2.5 was released six months ago, and the general cadence seems to be 3-6mo between releases. When is v2.6 slated for release? And what is the reason this commit is scheduled for 2.7? That would imply a wait of 6-9 months before we see this commit in a release version.

@majst01
Copy link
Collaborator

majst01 commented Jun 8, 2017

Oh no, 2.6 should be released in the next few days if not already release (it depends on support from som influxdata guys).
After 2.6 is out i would like to release 2.7 very shortly afterwards, only with a few important fixes.

@majst01
Copy link
Collaborator

majst01 commented Jun 8, 2017

2.6 is finally released.

@brettwooldridge
Copy link
Contributor Author

@majst01 Thanks!

@majst01
Copy link
Collaborator

majst01 commented Jun 12, 2017

Hi Brett,

one last nit, can you please add a proper changelog entry, after that i will merge it.
You should open a new 2.7 section therefore

@majst01 majst01 merged commit f5fe8ee into influxdata:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants