Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #468 Unit test to ensure tags should be sorted by key in line protocol (to reduce db server overheads) #476

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

lxhoan
Copy link
Contributor

@lxhoan lxhoan commented Jul 25, 2018

tags sorting has been ready bu using of TreeMap

I would like to add unit test to ensure the result

@lxhoan lxhoan requested a review from majst01 July 25, 2018 06:34
… reduce db

server overheads
add unit test
@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #476 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #476      +/-   ##
============================================
- Coverage     86.91%   86.84%   -0.08%     
  Complexity      303      303              
============================================
  Files            20       20              
  Lines          1292     1292              
  Branches        134      133       -1     
============================================
- Hits           1123     1122       -1     
  Misses          111      111              
- Partials         58       59       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/Query.java 63.15% <0%> (-2.64%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aac8f0...2d1c9bc. Read the comment docs.

@majst01 majst01 merged commit a59e4e6 into influxdata:master Jul 25, 2018
@lxhoan lxhoan deleted the tag_key_sorted branch July 27, 2018 07:53
@lxhoan lxhoan changed the title issue #468 tags should be sorted by key in line protocol to reduce db server overheads issue #468 Unit test to ensure tags should be sorted by key in line protocol (to reduce db server overheads) Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants