Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add implementation information to Jar manifest #847

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 29, 2022

Proposed Changes

Add default implementation entries to Jar manifest.

It is useful when you want to retrieve the client version by java code:

Package mainPackage = org.influxdb.InfluxDB.class.getPackage();
String version = mainPackage.getImplementationVersion();

The manifest will contain these entries:

  1. Implementation-Title: ${project.name}
  2. Implementation-Version: ${project.version}
  3. Implementation-Vendor: ${project.organization.name}

For more info see: https://maven.apache.org/shared/maven-archiver/.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 29, 2022 13:42
@bednar bednar requested a review from majst01 June 29, 2022 13:43
@majst01 majst01 merged commit 3d53a50 into master Jun 29, 2022
@majst01 majst01 deleted the manifest-update branch June 29, 2022 14:18
@bednar bednar added this to the 2.23 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants